secondlife / viewer

🖥️ Second Life's official client
GNU Lesser General Public License v2.1
209 stars 53 forks source link

Missing parameters in floater_fast_timers.xml generates warnings in log #970

Open canny[bot] opened 6 months ago

canny[bot] commented 6 months ago

Observe the log to see the following warning reported about invalid params for "doc_pos" and then "page_size". Really, I think the issue is that they're missing mandatory parameters rather than being invalid. An invalid parameter to me would suggest using a parameter that isn't defined within the C++ codebase or a param that has been typo'd. Another option is instead of dumping a warning for missing mandatory params, just assume (without warning) a default if not user-defined in XML?


2024-03-08T14:46:16Z WARNING # llcommon/llinitparam.cpp(217) LLInitParam::BaseBlock::validateBlock : Invalid param "doc_pos"

2024-03-08T14:46:16Z WARNING # llui/lluictrlfactory.h(217) LLUICtrlFactory::createWidgetImpl : D:\Program Files\SecondLifeViewer\skins\default\xui\en\floater_fast_timers.xml: Invalid parameter block for class LLScrollbar

Followed by...


2024-03-09T14:25:05Z WARNING # llcommon/llinitparam.cpp(217) LLInitParam::BaseBlock::validateBlock : Invalid param "page_size"

2024-03-09T14:25:05Z WARNING # llui/lluictrlfactory.h(217) LLUICtrlFactory::createWidgetImpl : D:\Program Files\SecondLifeViewer\skins\default\xui\en\floater_fast_timers.xml: Invalid parameter block for class LLScrollbar

I added the parameters to the XML file using the default values (according to llscrollbar.cpp) of 0 and no longer the warnings are present.

https://secondlife.canny.io/admin/board/bug-reports/p/missing-parameters-in-floater-fast-timersxml-generates-warnings-in-log

canny[bot] commented 6 months ago

This issue has been linked to a Canny post: Missing parameters in floater_fast_timers.xml generates warnings in log :tada:

dmytrohproductengine commented 5 months ago

Passed QA. Verified on Second Life Release 7.1.6.8632435333 (64bit) on Win10/OSX in the scope of secondlife/iqa#190.