secretkeylabs / xverse-core

Core library for Xverse wallet

Other

40 stars 20 forks source link

chore: type fixes #296

Closed teebszet closed 1 year ago

teebszet commented 1 year ago

🔘 PR Type

[x] Code style update (formatting, local variables)
[x] Build related changes

📜 Background

https://linear.app/xverseapp/issue/ENG-3129/fix-all-non-exported-types-from-xverse-core https://linear.app/xverseapp/issue/ENG-3327/fix-all-tsc-errors-on-web-extension

for https://github.com/secretkeylabs/xverse-web-extension/pull/685

🔄 Changes

Does this PR introduce a breaking change?

[ ] Yes, Incompatible API changes
[ ] No, Adds functionality (backwards compatible)
[x] No, Bug fixes (backwards compatible)

Changes:

mostly fixing the missing exports in the built dist
some type fixes

Impact:

can test on the extension PR

✅ Review checklist

Please ensure the following are true before merging:

[ ] Code Style is consistent with the project guidelines.
[ ] Code is readable and well-commented.
[ ] No unnecessary or debugging code has been added.
[ ] Security considerations have been taken into account.
[ ] The change has been manually tested and works as expected.
[ ] Breaking changes and their impacts have been considered and documented.
[ ] Code does not introduce new technical debt or issues.

github-actions[bot] commented 1 year ago

Test this PR with npm i --save-exact @secretkeylabs/xverse-core@3.1.0-d80fe62