secretkeylabs / xverse-core

Core library for Xverse wallet

Other

40 stars 20 forks source link

Use effective feerate in calcs #316

Closed victorkirov closed 11 months ago

victorkirov commented 1 year ago

🔘 PR Type

What kind of change does this PR introduce?

[x] Enhancement

📜 Background

Allow the use of effective fee rate rather than fee rate when calculating txn fees.

🔄 Changes

Does this PR introduce a breaking change?

[ ] Yes, Incompatible API changes
[x] No, Adds functionality (backwards compatible)
[ ] No, Bug fixes (backwards compatible)

Impact:

We need to implement the use of this in the frontends

✅ Review checklist

Please ensure the following are true before merging:

[ ] Code Style is consistent with the project guidelines.
[ ] Code is readable and well-commented.
[ ] No unnecessary or debugging code has been added.
[ ] Security considerations have been taken into account.
[ ] The change has been manually tested and works as expected.
[ ] Breaking changes and their impacts have been considered and documented.
[ ] Code does not introduce new technical debt or issues.

github-actions[bot] commented 11 months ago

Test this PR with npm i --save-exact @secretkeylabs/xverse-core@7.0.0-8a7edb3