secretkeylabs / xverse-web-extension

Other
46 stars 25 forks source link

[ENG-3436] chore: Make some code refactoring for RBF in the extension #712

Closed dhriaznov closed 10 months ago

dhriaznov commented 11 months ago

🔘 PR Type

What kind of change does this PR introduce?

📜 Background

After the RBF UI & logic were added to the web-extension, we also developed it for the mobile app. And some things could be improved in its code like constants, typing, etc. (kudos to @fedeerbes for the mobile app PR review)

This PR is made to address those things for the web extension as well.

Issue Link: #[ENG-3436] Context Link (if applicable):

🔄 Changes

Impact:

🖼 Screenshot / 📹 Video

Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.

✅ Review checklist

Please ensure the following are true before merging:

dhriaznov commented 11 months ago

Thanks for the review @teebszet! I updated the PR, and also included the fix from https://github.com/secretkeylabs/xverse-web-extension/pull/713 you created since it's related and would be better to test those 2 PRs together. Could you approve it again pls? 🙂

dhriaznov commented 11 months ago

It would make sense to test and merge this PR together with https://github.com/secretkeylabs/xverse-web-extension/pull/727 in the next release (0.28.0)

github-actions[bot] commented 11 months ago

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7357186386

DuskaT021 commented 10 months ago

@dhriaznov this can be merged, tested per agreement