secretkeylabs / xverse-web-extension

Other
46 stars 25 forks source link

chore: add new auto lock period values and migrate users if needed #736

Closed fedeerbes closed 10 months ago

fedeerbes commented 11 months ago

🔘 PR Type

📜 Background

This PR adds new auto lock period options and migrates users from older values (1' or 10') to new low value 15' if needed. Default value now is 30'

Issue Link: #ENG-3527

Impact:

🖼 Screenshot / 📹 Video

NORMAL FLOW SIMULATED UPDATE

✅ Review checklist

Please ensure the following are true before merging:

dhriaznov commented 11 months ago

It looks like currently the 15 minutes option timer icon has opacity set to 1, but all other icons have 0.8. I took a look at figma and from what I see it should be dynamic, so that the active option icon should have an opacity 1 and all other icons should have 0.8

https://www.figma.com/file/FCk8jDMsC8UEfPSWnqewLY/Xverse-%E2%80%94-Extension-V2?node-id=11693%3A13820&mode=dev

fedeerbes commented 10 months ago

It looks like currently the 15 minutes option timer icon has opacity set to 1, but all other icons have 0.8. I took a look at figma and from what I see it should be dynamic, so that the active option icon should have an opacity 1 and all other icons should have 0.8

https://www.figma.com/file/FCk8jDMsC8UEfPSWnqewLY/Xverse-%E2%80%94-Extension-V2?node-id=11693%3A13820&mode=dev

you're right, thanks! i took them from mobile and i didn't check that detail. will make the change

github-actions[bot] commented 10 months ago

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7446488620