secretkeylabs / xverse-web-extension

Other
46 stars 25 forks source link

Send btc integrate with tx consolidation logic #766

Closed victorkirov closed 9 months ago

victorkirov commented 10 months ago

NOTE: depends on https://github.com/secretkeylabs/xverse-core/pull/346

🔘 PR Type

What kind of change does this PR introduce?

📜 Background

This introduces the use of the new txn logic for the send btc screen. Additionally it adds the send max functionality.

🔄 Changes

The send btc screen was rewritten to use the new txn logic.

Impact:

🖼 Screenshot / 📹 Video

https://github.com/secretkeylabs/xverse-web-extension/assets/3322667/02778166-9cd8-44c7-8e26-229515983a67

✅ Review checklist

Please ensure the following are true before merging:

teebszet commented 10 months ago

looks good! just wanna tidy up the edit fees spacing and feedback item a bit, otherwise good by me :)

victorkirov commented 10 months ago

For the spinners, should we migrate them all to the new one?

teebszet commented 10 months ago

For the spinners, should we migrate them all to the new one?

yeah that should be pretty low risk

teebszet commented 10 months ago

reminder to myself: test with ledger

teebszet commented 10 months ago

fyi ledger happy path passed with flying colours 🎉

github-actions[bot] commented 9 months ago

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7913360440