secretkeylabs / xverse-web-extension

Other
46 stars 25 forks source link

Fix typing between sats connect and extension for providers #768

Closed victorkirov closed 10 months ago

victorkirov commented 10 months ago

Note: This PR needs to be merged and published: https://github.com/secretkeylabs/sats-connect/pull/59

πŸ”˜ PR Type

What kind of change does this PR introduce?

πŸ“œ Background

With the XverseProvider object being types in sats-connect on the window object, the typing was not extendable and it resulted in typescript clashes.

πŸ”„ Changes

The type was extracted into its own extendable interface in sats connect. This PR requires sats-connect tobe bumped and upgraded and the types are subsequently fixed with the interface correctly extended with the stacks provider.

This is a typing change, so there are no functional changes to test.

βœ… Review checklist

Please ensure the following are true before merging:

github-actions[bot] commented 10 months ago

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7653146693