secretkeylabs / xverse-web-extension

Other
46 stars 24 forks source link

Remove fee subtraction from the You Will Transfer total - ENG-3699 #787

Closed victorkirov closed 8 months ago

victorkirov commented 8 months ago

πŸ”˜ PR Type

What kind of change does this PR introduce?

πŸ“œ Background

When showing a transaction summary, we calculate the total amount transferred as the total inputs from your address - the total outputs from your address - fee. This is potentially incorrect as we are assuming that the user is paying the fee, when they aren't necessarily.

πŸ”„ Changes

No longer subtract the fee from the total being transferred.

Impact:

βœ… Review checklist

Please ensure the following are true before merging:

github-actions[bot] commented 8 months ago

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7753997029