securedeveloper / react-data-export

Export dataset in react.
https://securedeveloper.github.io/react-data-export/
MIT License
179 stars 191 forks source link

Incorrect type definition - ExcelCell #141

Open samuelhulla opened 3 years ago

samuelhulla commented 3 years ago

Hello, I actually ran across this randomly while answering a question on stackoverflow, but either way

The current the typescript definition for ExcelCell is incorrect

(and retro-actively where it's used)

Current definition:

interface ExcelCell {
    value: ExcelCell;
    style: ExcelStyle;
}

This obviously makes no sense and would require you to recursively declare the ExcelCell inside the value property.

Supposed to be

interface ExcelCell {
    value: ExcelCellValue;
    style: ExcelStyle;
}