search

securefederatedai / openfl

An Open Framework for Federated Learning.
https://openfl.readthedocs.io/en/latest/index.html
Apache License 2.0
734 stars 207 forks source link

Flake8 linter fixes + updating PR lint rules #1130

Closed teoparvanov closed 2 weeks ago

teoparvanov commented 3 weeks ago

Here we update the ubuntu.yml workflow to use the same (OpenFL-specific) lint rules as the lint.yml workflow that runs as part of the PR pipeline.

MasterSkepticista commented 3 weeks ago

@teoparvanov Those do not appear in Lint CI because there are exceptions to flake8 provided via a config file in shell/lint.sh, and it only covers source code, no examples/tutorials/templates.

I think we need to remove all flake8 checks elsewhere. Any exceptions should be captured in setup.cfg.

teoparvanov commented 3 weeks ago

@teoparvanov Those do not appear in Lint CI because there are exceptions to flake8 provided via a config file in shell/lint.sh, and it only covers source code, no examples/tutorials/templates.

I think we need to remove all flake8 checks elsewhere. Any exceptions should be captured in setup.cfg.

Thanks for pointing this out, @MasterSkepticista , I wasn't aware of the setup.cfg file. Let me take a look and I'll update the PR accordingly.