search

securefederatedai / openfl

An Open Framework for Federated Learning.
https://openfl.readthedocs.io/en/latest/index.html
Apache License 2.0
734 stars 207 forks source link

[WIP] Workflow-api based notebook tutorial for tensotflow.keras mnist based model with FedProx #1145

Open yontyon opened 2 weeks ago

rahulga1 commented 1 week ago

@kta-intel do we want to have modified FedProxOptimizer code part of tutorial? Or should we modified it in the framework code itself. I know it will be reworked part of Keras 3 support in OpenFL.

kta-intel commented 1 week ago

@kta-intel do we want to have modified FedProxOptimizer code part of tutorial? Or should we modified it in the framework code itself. I know it will be reworked part of Keras 3 support in OpenFL.

In my opinion, I recommend not modifying FedProx inline for this tutorial. I think it would be better to update the framework code itself. I mentioned it in one of the review threads because I missed your message (sorry), but FedProx actually exists outside the taskrunner, so the efforts to upgrade the taskrunner to Keras3 would not capture FedProx. It would be more impactful to get that upgraded at the framework level