search

security-dockerfiles / beef

Dockerized BeEF
MIT License
44 stars 14 forks source link

Password is regenerated when restarting container #5

Closed cnotin closed 3 years ago

cnotin commented 3 years ago

Thanks for this nice image :)

The random password generation feature is a nice addition! But I just noticed that a new password is generated every time the container is re-started (docker restart beef) and displayed in the console. However it is not changed in the config file because the default "beef" value is not present anymore: https://github.com/security-dockerfiles/beef/blob/a4feaeaf124bd7225227c28d38524bb6a0ccf799/entrypoint.sh#L10

Two options:

  1. do not re-generate password if already changed
  2. properly reset in the config file

Having a new, new password is annoying (since the previous one was already strong and random) so I'll suggest soon a PR for 1.