search

seed-rs / seed

A Rust framework for creating web apps
MIT License
3.81k stars 155 forks source link

add example of using CustomEvent to custom_elements example #588

Closed glennsl closed 3 years ago

glennsl commented 3 years ago

This is rather contrived, but does an OK job at illustrating how to use custom events I think. I'm very open to suggestions though.

It might also be an idea to convert this into a component builder for a nicer API, but maybe that will complicate the example too much.

glennsl commented 3 years ago

cargo make verify passes locally, not sure why it fails on CI with:

 Error during execution of `cargo metadata`:     Updating crates.io index
error: failed to select a version for the requirement `shipyard = "^0.4.1"`
candidate versions found which didn't match: 0.5.0

cargo update locally yields the same error though

MartinKavik commented 3 years ago

Please remove **/Cargo.lock from .gitignore and push all your locks to the repo. I started to do it in all my repos because I have to often resolve similar dependency issues. Code looks good on the first glance, I'll merge it then.

glennsl commented 3 years ago

Done. Yea we do the same.