segler-alex / RadioDroid

radio browser app that uses www.radio-browser.info on android
GNU General Public License v3.0
727 stars 152 forks source link

RadioDroid does not show station icons #915

Open Vingolf opened 3 years ago

Vingolf commented 3 years ago

I found some station icons on radio-browser.info

Nirvana_Radio-02

that are not displayed in the RadioDroid app: Nirvana_Radio

I wonder why RadioDroit does not display neither the the jpeg-Image for Nirvana Radio nor the icon for Nirvana.

werman commented 3 years ago

That's a strange case, indeed icons are not retrieved. Enabling logs shows:

net.programmierecke.radiodroid2 D/Picasso: Main        created      [R46] Request{http://www.108.pl/public/images/listener.jpg resize(183,0)}
net.programmierecke.radiodroid2 D/Picasso: Hunter      executing    [R45]+1ms 
net.programmierecke.radiodroid2 D/Picasso: Main        errored      [R43]+11s HTTP 403

There is either HTTP 403 or 504 error code. While the same images could be easily viewed in a browser or downloaded via curl e.g.: curl -X GET -H "Cache-Control: no-cache" -H "User-Agent: RadioDroid2/0.83" "http://www.108.pl/public/images/listener.jpg"

werman commented 3 years ago

Hmmm, it doesn't look like an issue on RadioDroid's side. I think that website denies requests for some reason.

Vingolf commented 3 years ago

it doesn't look like an issue on RadioDroid's side. I think that website denies requests for some reason.

Let's take this favicon as an example:

Nirvana Favicon 1 Nirvana Favicon 2

These two favicon are not taken from the radio station itself. I found them by image search on the internet.

Are there any references in which case it is legal to use such images found on the internet as favicons for a radio station? For the use on Radiodroid I think a radio stream should have

  1. a favicon at all,
  2. a favicon that is different from favicons of other streams of the same radio station (in this case, Nirvana Radio Ambient should have a different favicon than Nirvana Radio Meditation).