search

sehugg / dithertron

Retro 8-bit bitmap converter supporting many formats
GNU General Public License v3.0
75 stars 11 forks source link

Makefile on windows #27

Closed robin-raymond closed 1 year ago

robin-raymond commented 1 year ago

I suggest you REJECT this PR. I just wanted to show why the Makefile fails on Windows. The @ commands don't work because they are using linux commands. The Makefile could be make to work on both systems. I'm not a Makefile expert though so I don't want to propose the "right" way to do it. distro/watch targets will have the same issues but they aren't as vital to get going.

sehugg commented 1 year ago

Eh, it looks fine. Just needs a note in the README. I only added the @'s because it was running before every build, now you run it just once so I think they can go away.

robin-raymond commented 1 year ago

Right the @'s are the problem. The problem being linux and windows use different command flavors. I think there's a way to create symbolic commands that are defined per platform but I leave that to someone else... I'll add to readme. At least it gets people going!

robin-raymond commented 1 year ago

Done.