seismology / mc_kernel

Calculate seismic sensitivity kernels using Axisem
GNU General Public License v3.0
24 stars 8 forks source link

S kernel bugfix #70

Open kasra-hosseini opened 5 years ago

kasra-hosseini commented 5 years ago

@EoghanTotten reported the following fixes: (@harriet-godwin and @sstaehler, would you please confirm these changes?)

https://github.com/seismology/mc_kernel/blob/9c534a9bf6346ffaf29453cfc5fb85e6f048d0bb/src/readfields.f90#L1294-L1296

should be changed to:

load_fw_points(:,:,ipoint) = rotate_symm_tensor_voigt_src_to_xyz( &
                                          load_fw_points(:,:,ipoint),        &
                                          rotmesh_phi(ipoint), this%ndumps    )

and

https://github.com/seismology/mc_kernel/blob/9c534a9bf6346ffaf29453cfc5fb85e6f048d0bb/src/readfields.f90#L1456-L1457

to:

load_bw_points(:,:,ipoint) = rotate_symm_tensor_voigt_src_to_xyz(load_bw_points(:,:,ipoint), &
                                          rotmesh_phi(ipoint), this%ndumps)
sstaehler commented 5 years ago

Yes, sounds reasonable to me. @harriet-godwin, do you agree?

harriet-godwin commented 5 years ago

Yes this is the rotation fix that I found a while ago and is correct

esleokan commented 5 years ago

I tested a simple SKS kernel at 100º distance in radial component. Now the S kernel shows the expected negative sensitivity in the first Fresnel zone. SKS_100