A few small fixes - Githubissues

davidepalazzo commented 7 years ago

Hi @DominicTobias

I came across this repo and liked it for its simplicity. I took the freedom to fix a few things (list below) that were throwing an error.

Added preset babel-eslint to the .eslintsrc. The way 'serverMiddleware' was exported made eslint trigger a prefer-default-export issue
Added Redux Devtools
parseQuery will soon be depracated in Webpack so to fix the warning message react-transform had to be moved from webpack to .babelrc as per the official guide
Swapped presets order in the .babelrc file so that is now possible to use state = {} without invoking the constructor method
Migrated to prop-types. React has deprecated PropTypes so a separate package needs to be used. Although the warning is still active due to some dependencies still using the old PropTypes
Fixed an issue in User.js where this.getUser().info was undefined and threw an error
Fixed an issue in User.js where user.info was undefined and threw an error (this was happening with a slow response from the api). The UserCard component was mounting before the request was fully executed

hugmanrique commented 7 years ago

👍 This PR should be merged, but the project seems to be inactive :(

sekoyo commented 7 years ago

This is awesome thanks so much.. somehow this escaped my radar until the comment

davidepalazzo commented 7 years ago

Has this been merged yet? 🤔

sekoyo commented 7 years ago

I thought it had been, I tried to merge it 35,000 feet in the air but I guess the wifi messed up, merged now thanks

sekoyo / universal-react