search

sekrit-twc / zimg

Scaling, colorspace conversion, and dithering library
Do What The F*ck You Want To Public License
405 stars 77 forks source link

Add `use_scene_referred` to `zimg_graph_builder_params` #196

Open Setsugennoao opened 1 year ago

Setsugennoao commented 1 year ago

As the title says, adds this param to the public API.

I also edited the test example to include it. I don't know if you didn't want the changelog to be updated, I can remove it ^^

Setsugennoao commented 1 year ago

Hi, is there anything I should modify for it to be merged? Is this not planned or wanted in the API?

sekrit-twc commented 1 year ago

scene_referred will be added when a verified use case arises. Otherwise, there will be much untested code exposed.

NSQY commented 1 year ago

scene_referred will be added when a verified use case arises. Otherwise, there will be much untested code exposed.

The original want for this option stems from this Doom9 thread: https://forum.doom9.org/showthread.php?p=1972723#post1972723

For what it's worth, AVS+ users have had access to this code for approximately a year. I will contact the maintainer to confirm.

NSQY commented 1 year ago

No known problems reported with the AVS+ build. Testing may be limited to the aforementioned post.