search

semaphore-protocol / semaphore

A zero-knowledge protocol for anonymous interactions.
https://semaphore.pse.dev
MIT License
928 stars 211 forks source link

`@semaphore-protocol/data` uses utility functions that can be replaced by `@zk-kit/utils` #773

Open cedoor opened 6 months ago

cedoor commented 6 months ago

Description

@semaphore-protocol/data uses checkParameters to check if the parameter types are the correct ones. Since there's already a @zk-kit/utils dependency, it could use the zk-kit utility error-handlers functions directly, and avoid duplicating code.

jancris100 commented 6 months ago

Can you assign this to me please?

vplasencia commented 6 months ago

Hey @jancris100 sure. I just assigned you this issue. Please, let us know if you have questions.

hannahredler commented 3 months ago

Hey! I'm Hannah, a developer studying with the PSE Core program :) If this isn't in progress already I would be happy to take it on. @vplasencia @jancris100

cedoor commented 2 months ago

Hey @hannahredler, there's already a PR for this issue. Let's try to ping the author and ask them first.

@jancris100 there are some issues to solve in your PR: https://github.com/semaphore-protocol/semaphore/pull/782. Let us know if you've time to work on it. Otherwise no problem, just a double-check before re-assigning the issue.

jancris100 commented 2 months ago

This issue i already finish it a long time ago

cedoor commented 2 months ago

@jancris100 great! Could you reply to my comments there? Some conflicts also need to be resolved.

Chirag-S-Kotian commented 2 weeks ago

@jancris100 then why this pr is not closed

cedoor commented 1 week ago

Hi @Chirag-S-Kotian, the PR has been closed as there has not been activity for a while.

The issue is open again to anyone who wants to contribute.

We give contributors ample time to work on good first issues as they are not a priority. However, please consider we need to set a time limit of a few months to prevent the codebase/PRs from becoming stagnant/outdated.