search

semprag / biblatex-sp-unified

An opinionated biblatex implementation of the Unified Stylesheet for Linguistics Journals
LaTeX Project Public License v1.3c
39 stars 12 forks source link

labeldate backcompat #27

Closed timmli closed 7 years ago

timmli commented 7 years ago

Adds backward compatibility with labeldate option and helps to avoid annoying updates of biblatex. Related to #23 and #25.

fintelkai commented 7 years ago

Thank you, @timmli. This looks good. Have you tested it against different versions of biblatex?

timmli commented 7 years ago

I've tested it against biblatex 3.4 and 3.6. It turned out that \printlabeldateextra backcompat was still missing, therefore another commit.

Biblatex 3.4 still throws an error, but this seems to have other reasons (see here):

./test.tex:14: Undefined control sequence.
<argument> \bbl@main@language

Biblatex 3.6 compiles without errors nor warnings.

This is what I used for testing:

\documentclass{article}

\usepackage[
  style=../bbx/biblatex-sp-unified,
  citestyle=../cbx/sp-authoryear-comp,
  ]{biblatex}
\bibliography{references}

\begin{document}
\cite{Bar-Hillel:53}
\printbibliography
\end{document}

BTW: Maybe it would be a good idea to add test cases to the repository?

fintelkai commented 7 years ago

Thanks @timmli. I've finally merged this PR.

Re: "BTW: Maybe it would be a good idea to add test cases to the repository?" → We do in fact have kind of a test. The repo includes unified-test.tex, which typesets the example bibliography from the Unified Stylesheet document. It's not a very sophisticated test setup but it can serve as a minimal canary in the coal mine.