search

senchalabs / connect

Connect is a middleware layer for Node.js
MIT License
9.84k stars 1.09k forks source link

chore: finalhandler #1141

Open alexander-akait opened 2 months ago

alexander-akait commented 2 months ago

Full HTTP/2 support without deprecation messages

Ref: https://github.com/pillarjs/finalhandler/pull/53

alexander-akait commented 2 months ago

/cc @dougwilson Can you look? Thank you

nyc has a breaking change, and stop working on Node.js@8 and Node.js@9

dougwilson commented 2 months ago

I am taking a look now to get this released asap

dougwilson commented 2 months ago

It is not clear what changes are all in these finalhandler releases. I opened https://github.com/pillarjs/finalhandler/issues/63 to get some clarity and will get this fully updated when I hear back 👍 . Most everything is ready to go here, however.

alexander-akait commented 2 months ago

As I can undestand by commit's history it is - https://github.com/pillarjs/finalhandler/blob/master/HISTORY.md#v121--2024-09-02 + Full HTTP/2 support without deprecation messages

dougwilson commented 2 months ago

I see you updated to 1.3.0 here but there is a 1.3.1 too. Should we update to that / what is in 1.3.1? I could not even find any commit in the report where 1.3.1 is in the package.json so I'm really confused what is going on there and my alarm bells in ym head are going off with what has happened in the past to projects upgrading, which is why I pin deps and review what exactly is being shipped out.

alexander-akait commented 2 months ago

@dougwilson I see, let's wait for an answer, if there is none I will research the commit history and write it here, but I agree that versions should not be missed

alexander-akait commented 1 month ago

@dougwilson Okay, let's finish it :smile: I was learning about changes between 1.3.0 and 1.3.1 - and it is - https://github.com/pillarjs/finalhandler/commit/dede5aa2354ea3d765bd9d2be08b0de22f253bc7, apparently the commits were not sent and the release was made locally, I will try to update v1.3.1, looks safe - https://github.com/pillarjs/encodeurl/releases/tag/v2.0.0 (no issues - https://github.com/pillarjs/encodeurl/issues)

alexander-akait commented 1 month ago

CI pass :star: