Closed LaikaN57 closed 4 years ago
Merging #142 into main will decrease coverage by
0.14%
. The diff coverage is93.75%
.
@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 92.73% 92.59% -0.15%
==========================================
Files 6 6
Lines 303 297 -6
==========================================
- Hits 281 275 -6
Misses 22 22
Impacted Files | Coverage Δ | |
---|---|---|
python_http_client/client.py | 81.25% <87.50%> (-0.20%) |
:arrow_down: |
tests/test_unit.py | 99.24% <100.00%> (-0.03%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1c09a8a...d1374d4. Read the comment docs.
I am no longer convinced that this was a good idea as it looks like requests
uses urllib3
which just uses http
. And my original assumption that urllib3
provided header logging was incorrect.
I would instead urge readers to just use this until we can get proper logging in the http
: https://stackoverflow.com/a/58769712/11015364
Fixes #141
This PR switches out the underlying HTTP library. Instead of using
urllib
(and related) which useshttp
under the hood and does not have configuration options for logging requests, we switch to using therequests
library which usesurllib3
under the hood and has a module level logger that we can modify to enable request logging.Checklist