Fix: Chats shown for agents even with 'hide_all_chats_for_agent' enabled.

CrimsonSunrise commented 1 month ago

The ChatList.vue component didn't had a function to verify if the current user wasn't an 'administrator' and if the current company had the flag 'hide_all_chats_for_agent' set to true to prevend rendering chats for agent users.

Two changes were made to make it work as intended:

The value of count which is responsible to show the chat counts on the tabs now displays always 0 if the user isn't 'administrator' and the current account has the flag 'hide_all_chats_for_agent' set to true.
The function that creates the chat list now returns an empty array if the user isn't 'administrator' and the current account has the flag 'hide_all_chats_for_agent' set to true.

Summary by CodeRabbit

New Features
- Enhanced visibility and filtering of conversations based on user roles, particularly for agents.
- Conditional display of conversation counts and lists depending on user permissions.
Bug Fixes
- Improved logic to ensure agents do not see conversations when applicable filters are activated.

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes in ChatList.vue focus on modifying the logic for displaying and filtering conversations based on user roles and permissions. A new condition, hideAllChatsForAgents, determines whether agents can view conversations, resulting in an empty list if true. The computed properties assigneeTabItems, conversationList, and conversationFilters have been updated to reflect this logic. Additionally, the mounted lifecycle hook and the resetAndFetchData method have been adjusted to ensure the UI accurately represents the current filter state.

Changes

File Path	Change Summary
app/javascript/dashboard/components/ChatList.vue	Updated `assigneeTabItems`, `conversationList`, and `conversationFilters` computed properties to include `hideAllChatsForAgents` logic. Modified `mounted` lifecycle hook to set chat list filters and adjusted `resetAndFetchData` method for new filtering logic.

Poem

In the land of chats so bright,
A new rule brings a clearer sight.
Agents now see, or not at all,
Conversations fade, like shadows tall.
With filters set and roles defined,
A smoother chat list, perfectly aligned! 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

AnxHall commented 3 weeks ago

nice one, test are okay? i have a question why not "this.currentRole !== 'administrator' ? 0"

CrimsonSunrise commented 3 weeks ago

nice one, test are okay? i have a question why not "this.currentRole !== 'administrator' ? 0"

Hey!

Because the function hideAllChatsForAgents already has a check for admin role.

AnxHall commented 3 weeks ago

But!.. understand that the logic for "role" admin is that the admin has already been created and identifies it, a bug is formed in a clean installation (direct installation environment outside of docker) where there is a "creation of account", a small modal, where you get stuck in it, after trying to access your "super_admin" login on the "dashboard"

test environment (. /setup --install) 24cpu 32g ram 400 NVME Localhost

sendingtk / chatwoot