coderabbitai[bot]
commented
4 days ago Walkthrough
The changes involve modifications to the placeholder text for the "EMAIL" input field across various localization JSON files for login and signup interfaces in English, Spanish, and Portuguese. The placeholder format has been altered to replace the "@" symbol with a string representation (e.g., "bruce{'@'}wayne.enterprises"), impacting how the placeholders are displayed to users. No structural changes were made to the JSON files, and no alterations to exported or public entity declarations were present.
Changes
| File Path | Change Summary |
|---|---|
| app/javascript/dashboard/i18n/locale/en/login.json | Updated "EMAIL" placeholder from "example@companyname.com" to "example{'@'}companyname.com". |
| app/javascript/dashboard/i18n/locale/en/signup.json | Updated "EMAIL" placeholder from "bruce@wayne.enterprises" to "bruce{'@'}wayne.enterprises". |
| app/javascript/dashboard/i18n/locale/es/login.json | Updated "EMAIL" placeholder from "example@companyname.com" to "example{'@'}companyname.com". |
| app/javascript/dashboard/i18n/locale/es/signup.json | Updated "EMAIL" placeholder from "bruce@wayne.enterprises" to "bruce{'@'}wayne.enterprises". |
| app/javascript/dashboard/i18n/locale/pt/login.json | Updated "EMAIL" placeholder from "example@companyname.com" to "example{'@'}companyname.com". |
| app/javascript/dashboard/i18n/locale/pt/signup.json | Updated "EMAIL" placeholder from "bruce@wayne.enterprises" to "bruce{'@'}wayne.enterprises". |
| app/javascript/dashboard/i18n/locale/pt_BR/login.json | Updated "EMAIL" placeholder from "example@companyname.com" to "example{'@'}companyname.com". |
| app/javascript/dashboard/i18n/locale/pt_BR/signup.json | Updated "EMAIL" placeholder from "bruce@wayne.enterprises" to "bruce{'@'}wayne.enterprises". |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
| Fix blank page after logout (Issue #10313) | ❌ | The changes do not address the blank page issue. |
🐰 In the land of code, where changes bloom,
Placeholders shift, dispelling the gloom.
From "@" to a string, they dance with delight,
A whimsical touch to the user's insight.
With every update, our app takes a leap,
Hopping through JSON, our promises we keep! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Vue i18n has a new linked message syntax. When it encounters @ it assumes that we're trying to use a linked message. And tries to parse it as such, in any case, it breaks since the syntax is not valid and the params are not present. So it causes an error. This works on dev but on production the error is bubbled up to the top and rendering breaks.
A lot of folks use Chatwoot with default locale set in the env, this surfaced the issue for the languages for which the syntax was not updated
Fixes: https://github.com/chatwoot/chatwoot/issues/10313 Pull: https://github.com/chatwoot/chatwoot/pull/10334
Summary by CodeRabbit
New Features
Bug Fixes