apply sort algorithm on aggregated data

nherment commented 10 years ago

Hi @mcollina,

I could not get the tests to pass locally, with my change or without. It's tested in a separate project. I still added the tests but I'm getting The following error:

➜  seneca-shard-store git:(master) ✗ npm test

> seneca-shard-store@0.0.6 test /Users/nherment/workspace/seneca-shard-store
> mocha test/

/Users/nherment/workspace/seneca-shard-store/test/shard.test.js:8
var shared = seneca.test.store.shared
                        ^
TypeError: Cannot read property 'store' of undefined
    at Object.<anonymous> (/Users/nherment/workspace/seneca-shard-store/test/shard.test.js:8:25)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at /Users/nherment/workspace/seneca-shard-store/node_modules/mocha/lib/mocha.js:172:27
    at Array.forEach (native)
    at Mocha.loadFiles (/Users/nherment/workspace/seneca-shard-store/node_modules/mocha/lib/mocha.js:169:14)
    at Mocha.run (/Users/nherment/workspace/seneca-shard-store/node_modules/mocha/lib/mocha.js:356:31)
    at Object.<anonymous> (/Users/nherment/workspace/seneca-shard-store/node_modules/mocha/bin/_mocha:359:16)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:906:3
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0

rjrodger commented 10 years ago

The store tests have been factored out into https://github.com/rjrodger/seneca-store-test Richard

On 2 Jul 2014, at 12:19, Nicolas Herment notifications@github.com wrote:

Hi @mcollina,

I could not get the tests to pass locally, with my change or without. It's tested in a separate project. I still added the tests but I'm getting The following error:

➜ seneca-shard-store git:(master) ✗ npm test

seneca-shard-store@0.0.6 test /Users/nherment/workspace/seneca-shard-store mocha test/

/Users/nherment/workspace/seneca-shard-store/test/shard.test.js:8 var shared = seneca.test.store.shared ^ TypeError: Cannot read property 'store' of undefined at Object. (/Users/nherment/workspace/seneca-shard-store/test/shard.test.js:8:25) at Module._compile (module.js:456:26) at Object.Module._extensions..js (module.js:474:10) at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12) at Module.require (module.js:364:17) at require (module.js:380:17) at /Users/nherment/workspace/seneca-shard-store/node_modules/mocha/lib/mocha.js:172:27 at Array.forEach (native) at Mocha.loadFiles (/Users/nherment/workspace/seneca-shard-store/node_modules/mocha/lib/mocha.js:169:14) at Mocha.run (/Users/nherment/workspace/seneca-shard-store/node_modules/mocha/lib/mocha.js:356:31) at Object. (/Users/nherment/workspace/seneca-shard-store/node_modules/mocha/bin/_mocha:359:16) at Module._compile (module.js:456:26) at Object.Module._extensions..js (module.js:474:10) at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12) at Function.Module.runMain (module.js:497:10) at startup (node.js:119:16) at node.js:906:3 npm ERR! Test failed. See above for more details. npm ERR! not ok code 0 You can merge this Pull Request by running

git pull https://github.com/nherment/seneca-shard-store master Or view, comment on, or merge it at:

https://github.com/mcollina/seneca-shard-store/pull/2

Commit Summary

apply sort algorithm on aggregated data File Changes

M index.js (40) M package.json (5) M test/shard.test.js (52) Patch Links:

https://github.com/mcollina/seneca-shard-store/pull/2.patch https://github.com/mcollina/seneca-shard-store/pull/2.diff — Reply to this email directly or view it on GitHub.