Closed mblaettler closed 4 years ago
I squashed your changes into my commit. There was also a change in Line 95&96 required.
In addition, I installed the plugin on our sensu instance to test it. It seems to work fine.
I will try to get a release out tonight or tomorrow.
I will try to get a release out tonight or tomorrow.
Thank you very much. Have a nice day and stay healthy. :-)
Sorry this slipped through I have cut a release and once CI passes it will be pushed to rubygems. I will check back later to make sure there are no hiccups.
Added -H/--header flag to pass custom HTTP headers in metrics-http-json.rb. This makes it possible to use authentication token or any other function based on HTTP headers.
Pull Request Checklist
Is this in reference to an existing issue?
176
General
[x] Update Changelog following the conventions laid out here
[x] Update README with any necessary configuration snippets
-> There was no entry about
metrics-http-json.rb
yet.[x] Binstubs are created if needed
[x] RuboCop passes
[x] Existing tests pass
Purpose
Currently it is not possible to pass custom HTTP headers to the request. This would be nice, because it would enable to use Authentication tokens or any other function based on HTTP headers.
Known Compatibility Issues