Closed luisdavim closed 7 years ago
Thanks for picking this up for the original submitter. Can you please include a changelog entry and a testing artifact ?
Sorry, I didn't noticed the changelog was missing.
And here's the test artifact:
$ /opt/sensu/embedded/bin/ruby /opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/sensu-plugins-sensu-2.3.1/bin/check-aggregate.rb -a http://localhost:4567 -c dcos-check-agent-node-health-aggregate -s --warning_count 1 --critical_count 1 -l 1 -A 120
CheckAggregate OK: Aggregate looks Good
$ /opt/sensu/embedded/bin/ruby /opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/sensu-plugins-sensu-2.3.1/bin/check-aggregate.rb -a http://localhost:4567 -c dcos-check-agent-node-health-aggregate -s --warning_count 1 --critical_count 1 -l 1 -A 120 --debug
CheckAggregate OK: Aggregate looks GOOD
{:ok=>3, :warning=>0, :critical=>0, :unknown=>0, :total=>3, :stale=>0}
Pull Request Checklist
This is to replace #37 since the original author was not responsive.
General
[x] Update Changelog following the conventions laid out on Our CHANGELOG Guidelines
[ ] Update README with any necessary configuration snippets
[x] Binstubs are created if needed
[x] RuboCop passes
[x] Existing tests pass
New Plugins
[ ] Tests
[ ] Add the plugin to the README
[ ] Does it have a complete header as outlined here
Purpose
Change the output message to a more standard format.
Known Compatibility Issues