Closed webframp closed 3 years ago
Build is failing because of a travis issue it looks like, tests pass locally. Possibly related to https://github.com/travis-ci/travis-ci/issues/8720
Not fighting with travis tonight. Will let this sit and see if it persists.
That sounds like we need to add their key for apt to accept it. Have we tried this? https://docs.chef.io/packages/#debian--ubuntu
That sounds like we need to add their key for apt to accept it. Have we tried this? https://docs.chef.io/packages/#debian--ubuntu
I figured, although we didn't have to do that previously I thought. Will update the config on this PR
Tested the chef instructions locally using docker ubuntu:18:04
https://docs.chef.io/packages/#debian--ubuntu and get:
E: The repository 'https://packages.chef.io/repos/apt/current bionic Release' is not signed.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
Strange that we have never hit this before. Going to test using https://docs.chef.io/packages/#chef-software-install-script install method in CI env
@majormoses fixed here.
I left it out but we should probably remove foodcritic
from ci in the future per https://blog.chef.io/goodbye-foodcritic/
Squashed the in between commits while testing CI adjustments
Don't usually like to merge my own stuff, but I'll merge this one since it fixes broken travis ci and Chef 16 compatibility.
fyi @cwjohnston @calebhailey
Thanks, @webframp
Thank you too @majormoses 🙌
Upstream chef/chef introduced changes that broke default .to_yaml behavior used in agent and backend resources.
As discussed in the related issues using
YAML.dump
will ensure the library autoloads correctly. Switched to this method instead of usingrequires
for consistency.fixes #104
refs:
Pull Request Checklist
Is this in reference to an existing issue?
Yes. Fixes #104
General
[x] Update Changelog following the conventions laid out here
[x] Update README with any necessary configuration snippets
[x] Cookstyle (rubocop) passes
[x] Foodcritic passes
[x] Rspec (unit tests) passes
[x] Inspec (integration tests) passes
Purpose
Fix issues with latest Chef 16.x releases
Known Compatibility Issues
None