sentry-kubernetes / charts

Easily deploy Sentry on your Kubernetes Cluster
MIT License
1.08k stars 514 forks source link

Missing S3 sentry configuration in newer charts from 20.0.0 onwards #1562

Open swade1987 opened 2 days ago

swade1987 commented 2 days ago

Issue Description

In versions of the Sentry Helm chart up to 20.0.0, S3 configuration options were available in the config.yml section of the configmap-sentry.yaml file. These options were located here.

However, starting from version 22.1.0 of the chart, these S3 configuration options have been removed.

Questions

  1. What is the reason for removing these S3 configuration options in version 22.1.0?
  2. Is S3 no longer a supported backend for Sentry?
  3. If S3 is still supported, how should users configure S3 as a backend in versions 22.1.0 and later of the chart?

Impact

Removing these options necessitates additional modifications to our forked chart to maintain S3 support. This is causing frustration and additional maintenance overhead as we try to keep our fork up-to-date with the latest changes.

Additional Context

Requested Action

Could the maintainers please provide guidance on:

  1. The current status of S3 support in the Sentry chart
  2. The recommended way to configure S3 in versions 22.1.0 and later of the chart (if still supported)
  3. Any plans to reintroduce these configuration options in future releases
  4. If there's any documentation or migration guide for users who were relying on these S3 configuration options

Any insights would be greatly appreciated as we work to maintain our forked version of the chart.

swade1987 commented 2 days ago

I have to add these whole section for services like ingest replay recording to work without borking

  {{/*  START - THIS WHOLE SECTION WAS REMOVED IN v20.0.0 OF THE CHART */}}
  {{- if eq .Values.filestore.backend "s3" }}
  filestore.options:
    {{- if .Values.filestore.s3.encryption }}
    encryption: {{ .Values.filestore.s3.encryption | quote }}
    {{- end }}
    {{- if .Values.filestore.s3.accessKey }}
    access_key: {{ .Values.filestore.s3.accessKey | quote }}
    {{- end }}
    {{- if .Values.filestore.s3.secretKey }}
    secret_key: {{ .Values.filestore.s3.secretKey | quote }}
    {{- end }}
    {{- if .Values.filestore.s3.bucketName }}
    bucket_name: {{ .Values.filestore.s3.bucketName | quote }}
    {{- end }}
    {{- if .Values.filestore.s3.endpointUrl }}
    endpoint_url: {{ .Values.filestore.s3.endpointUrl | quote }}
    {{- end }}
    {{- if .Values.filestore.s3.signature_version }}
    signature_version: {{ .Values.filestore.s3.signature_version | quote }}
    {{- end }}
    {{- if .Values.filestore.s3.region_name }}
    region_name: {{ .Values.filestore.s3.region_name | quote }}
    {{- end }}
    {{- if .Values.filestore.s3.default_acl }}
    default_acl: {{ .Values.filestore.s3.default_acl | quote }}
    {{- end }}
    #add comfig params for s3
    {{- if .Values.filestore.s3.addressing_style }}
    addressing_style: {{ .Values.filestore.s3.addressing_style | quote }}
    {{- end }}
    {{- if .Values.filestore.s3.location }}
    location: {{ .Values.filestore.s3.location | quote }}
    {{- end }}
  {{ end }}
  {{/*  END - THIS WHOLE SECTION WAS REMOVED IN v20.0.0 OF THE CHART */}}
nadecancode commented 2 days ago

Confused me because I just got S3 working 3 days ago without chart change. It seems like filestore.options got moved to SENTRY_OPTIONS['filestore.options']`

swade1987 commented 15 hours ago

Confused me because I just got S3 working 3 days ago without chart change. It seems like filestore.options got moved to SENTRY_OPTIONS['filestore.options']`

It only seems to be being set in the .py file and not the config file though 🤔