Open swade1987 opened 2 days ago
I have to add these whole section for services like ingest replay recording
to work without borking
{{/* START - THIS WHOLE SECTION WAS REMOVED IN v20.0.0 OF THE CHART */}}
{{- if eq .Values.filestore.backend "s3" }}
filestore.options:
{{- if .Values.filestore.s3.encryption }}
encryption: {{ .Values.filestore.s3.encryption | quote }}
{{- end }}
{{- if .Values.filestore.s3.accessKey }}
access_key: {{ .Values.filestore.s3.accessKey | quote }}
{{- end }}
{{- if .Values.filestore.s3.secretKey }}
secret_key: {{ .Values.filestore.s3.secretKey | quote }}
{{- end }}
{{- if .Values.filestore.s3.bucketName }}
bucket_name: {{ .Values.filestore.s3.bucketName | quote }}
{{- end }}
{{- if .Values.filestore.s3.endpointUrl }}
endpoint_url: {{ .Values.filestore.s3.endpointUrl | quote }}
{{- end }}
{{- if .Values.filestore.s3.signature_version }}
signature_version: {{ .Values.filestore.s3.signature_version | quote }}
{{- end }}
{{- if .Values.filestore.s3.region_name }}
region_name: {{ .Values.filestore.s3.region_name | quote }}
{{- end }}
{{- if .Values.filestore.s3.default_acl }}
default_acl: {{ .Values.filestore.s3.default_acl | quote }}
{{- end }}
#add comfig params for s3
{{- if .Values.filestore.s3.addressing_style }}
addressing_style: {{ .Values.filestore.s3.addressing_style | quote }}
{{- end }}
{{- if .Values.filestore.s3.location }}
location: {{ .Values.filestore.s3.location | quote }}
{{- end }}
{{ end }}
{{/* END - THIS WHOLE SECTION WAS REMOVED IN v20.0.0 OF THE CHART */}}
Confused me because I just got S3 working 3 days ago without chart change. It seems like filestore.options
got moved to SENTRY_OPTIONS['filestore.options']`
Confused me because I just got S3 working 3 days ago without chart change. It seems like
filestore.options
got moved to SENTRY_OPTIONS['filestore.options']`
It only seems to be being set in the .py file and not the config file though 🤔
Issue Description
In versions of the Sentry Helm chart up to 20.0.0, S3 configuration options were available in the
config.yml
section of theconfigmap-sentry.yaml
file. These options were located here.However, starting from version 22.1.0 of the chart, these S3 configuration options have been removed.
Questions
Impact
Removing these options necessitates additional modifications to our forked chart to maintain S3 support. This is causing frustration and additional maintenance overhead as we try to keep our fork up-to-date with the latest changes.
Additional Context
Requested Action
Could the maintainers please provide guidance on:
Any insights would be greatly appreciated as we work to maintain our forked version of the chart.