Don't eagerly remove semantically meaningless characters from queries and params

seomoz / url-cpp

C++ bindings for url parsing and sanitization

MIT License

19 stars 11 forks source link

Don't eagerly remove semantically meaningless characters from queries and params #29

Closed dlecocq closed 8 years ago

dlecocq commented 8 years ago

Introduce a new function, strip() which does what used to be automatic -- the removal of meaningless excess ?'s and &'s from queries and ;'s from params.

@b4hand @neilmb @lindseyreno

dlecocq commented 8 years ago

The progression of the commits is:

Keep the existing functionality, but use has_params_ and has_query_ variables
Keep the existing functionality but move it to a separate method, strip()
Change functionality by removing the automatic call to strip()

Perhaps that context will make it easier to review.

dlecocq commented 8 years ago

I had wanted to do this for a while, but I feared being disruptive to url-py clients. I want all transforms to be opt-in, and for parsing to do just that -- parsing.