sergeykhbr / riscv_vhdl

Portable RISC-V System-on-Chip implementation: RTL, debugger and simulators
http://sergeykhbr.github.io/riscv_vhdl/
Apache License 2.0
627 stars 104 forks source link

Check for failed invocations which would cause the debugger to crash. #3

Closed jrrk closed 8 years ago

jrrk commented 8 years ago

Dear Sergey, Thank you for sharing this very interesting project. The idea of using ethernet for debugging is very advanced and at the same time straightforward. However since you work mostly on Windows you may not have noticed some issues on Linux, specifically, not checking for dereferencing NULL pointers, not specifically targeting the correct IP address when binding the socket, and overwriting the same object file during compilation with a different compilation flag, also phony targets meaning the entire debugger has to be rebuilt every time. I believe these changes are of general benefit for your next version, however I cannot say if the Windows behaviour will be compromised, so I won't be at all offended if you don't accept them.

Regards, Dr Jonathan Kimmitt MA PhD CEng MIET Research Associate Computational Chemistry University of Cambridge

Commitlog


Correct dependencies in various makefiles. Add -g flags globally to detect crash causes. Force listen command to use correct IP address. Inform if no appropriate IP is available.