search

sergeyt / meteor-typeahead

Autocomplete package for meteor powered by twitter typeahead.js
https://atmospherejs.com/sergeyt/typeahead
MIT License
146 stars 82 forks source link

Updating typeahead from maintained forks #160

Open janat08 opened 6 years ago

janat08 commented 6 years ago

The original typeahead is no longer maintained, but there's maintained one here: https://github.com/corejavascript/typeahead.js Would it be possible to merge their udpates?

sergeyt commented 6 years ago

@janat08 sure if someone makes a PR with this update, please feel free to be the first one :)

janat08 commented 6 years ago

Lol, I just tried making a pull request from the maintained version, and it told me that they can't be compared, the idea then is to do this by hand?

sergeyt commented 6 years ago

yes you could just replace typeahead.bundle.js file, or consider to check getting dependency from npm. AFAIK meteor is capable to work with npm these days.

janat08 commented 6 years ago

oh right.

janat08 commented 6 years ago

Well I settled for just updating the bundle which lets me bind custom events which I think didn't happen previously. The sad thing that ele.focus() doesn't work still.