search

serilog-contrib / serilog-sinks-slack

A simple (yet customizable) Slack logging sink for Serilog
MIT License
41 stars 27 forks source link

Convert Project to .NET Standard and disposal reordering #24

Closed TrapperHell closed 3 years ago

TrapperHell commented 4 years ago
ps30 commented 3 years ago

Great and thanks for keeping this project fresh. If this PR does not get in soon, have you thought about pushing a NuGet package from your repo? Any plans for .Net 5 support?

TrapperHell commented 3 years ago

Thanks for your comment. Yes, publishing from my own repo is one of the options - considering that I also have made some other changes (in other branches), and the original developer does not seem inclined to take action upon it.

There is currently no code targeting .Net 5, but since it's targeting .Net Standard (starting off from 1.1), I don't see that it will be a big deal to include .Net 5 support.

mgibas commented 3 years ago

Indeed I’m out of this project (.net entirely) - I can add you as the collaborator or archive it so you can continue on the other repo, whatever you guys think would work best. Let me know what do you think

TrapperHell commented 3 years ago

I guess I am mostly concerned about the NuGet users that will be stuck with an outdated version. I suspect that adding me as a collaborator will do very little with keeping the NuGet up-to-date with future versions.

Unless I am mistaken in my previous statement, I would think that the best way to go forward would be to - if it is possible for you, review / approve / merge this PR and do one final update to your NuGet version so that at least users of the NuGet package can get the QoL updates. Regardless of whether or not this is possible, maybe archive it and optionally set a note to my updated repo?

Those are my thoughts on it. Does this work with you?

mgibas commented 3 years ago

Ok let’s start from bumping major version number (appveyor.yml is most important I believe) and merge this PR so it will be available on nuget and we can think about next steps.

mgibas commented 3 years ago

On the other note - if collaborators can modify GitHub workflows (not sue why wouldn’t) I could just add a nuget secret and you would have full control over the whole process

TrapperHell commented 3 years ago

Version has been bumped to 2.0 for both the appveyor file and the csproj (for good measure).

ps30 commented 3 years ago

@mgibas or @TrapperHell can one of you merge this PR and squeeze out the updated NuGet now that this is 2.0

mgibas commented 3 years ago

Let’s see what’s gonna happen 😀

mgibas commented 3 years ago

assembly patching failed on appveyor:

Build started
2git clone -q --branch=master https://github.com/mgibas/serilog-sinks-slack.git C:\projects\serilog-sinks-slack
3git checkout -qf eee55d9dfb5c34905df44f32aa8f369c41ff7717
4Patching AssemblyInfo
5No AssemblyInfo files found matching '**\AssemblyInfo.*'
6nuget restore src/Serilog.Sinks.Slack.sln
7Input file does not exist: src/Serilog.Sinks.Slack.sln.
8Command exited with code 1

what do you guys want me to do ?

TrapperHell commented 3 years ago

😨 sorry about that!

Well, AssemblyInfo doesn't exist anymore with .net core so that's one thing... As for the solution file error, there is no src directory to begin with.

mgibas commented 3 years ago

That’s fine :) I figured assembly patching and that missing src, now I just need a proper build command (previous msbuild does not make a cut :) ).

TrapperHell commented 3 years ago

I might be missing something, but appveyor.yml is already set to use dotnet instead of msbuild. The file contains the dotnet restore / pack commands, but a build can be done using the dotnet build command should that be necessary.

mgibas commented 3 years ago

Yeah, not sure why appveyor wasn't using that file. Either way I removed it from appveyor and added GH action - nugget key is in the repo secret so you guys have a full control over this package and its build/publish process. IM OUT! Have fun :)

TrapperHell commented 3 years ago

Good stuff with that! One last thing before you see yourself officially out lol, I don't suppose you've actually added me as a collaborator to the project? Or if you have, I'm not sure I have the right rights. It doesn't seem like I can push to this repository and neither issue builds. Unless you still want to oversee that aspect?

mgibas commented 3 years ago

You are right, my bad! 🤦🏼‍♂️ Done :)