serilog-mssql / serilog-sinks-mssqlserver

A Serilog sink that writes events to Microsoft SQL Server and Azure SQL
Apache License 2.0
276 stars 147 forks source link

period or batchPeriod? #528

Closed miksh7 closed 5 months ago

miksh7 commented 5 months ago

From readme file:

XML configuration <BatchPostingLimit Value="150"/> <BatchPeriod Value="00:00:15"/>

JSON Configuration "batchPostingLimit": 1000, "period": "0.00:00:30"

Is "period" name correct? What is batch period value format - [dd.]hh:mm:ss?

ckadluba commented 5 months ago

The JSON snippet in the README is incorrect. The sink option is in fact called batchPeriod.

Thank you for pointing this out. I'll fix it in the readme.