search

serilog / serilog-extensions-hosting

Serilog logging for Microsoft.Extensions.Hosting
Apache License 2.0
141 stars 34 forks source link

Add .NET 6 to other target frameworks, add conditions based on TFM for Nuget packages. #57

Closed ArminShoeibi closed 1 year ago

ArminShoeibi commented 2 years ago

Hello dear Nicholas. This pull request adds .NET6 to other TFMs and use conditions for installing dependencies. I Bumped TFM of sample projects to .NET 6. Everything is okay.

image
nblumhardt commented 2 years ago

Thanks for the PR! 😎

AppVeyor worker will need to be the VS 2022 one in order to use the 6.0 SDK (see appveyor.yml).

ArminShoeibi commented 2 years ago

Thanks for the PR! 😎

AppVeyor worker will need to be the VS 2022 one in order to use the 6.0 SDK (see appveyor.yml).

You are most welcome.🌹 Done.

nblumhardt commented 1 year ago

Thank you again for pushing this forwards @ArminShoeibi, sorry I somewhat dropped the ball at this end :-)

71 now finally resolves this, in a way that we can make consistent across all the various Microsoft.Extensions.*-related Serilog packages.

ArminShoeibi commented 1 year ago

Thank you again for pushing this forwards @ArminShoeibi, sorry I somewhat dropped the ball at this end :-)

71 now finally resolves this, in a way that we can make consistent across all the various Microsoft.Extensions.*-related Serilog packages.

That's great, happy to see version 7 of dependencies 😁