Fix ExceptionTokenRenderer to WriteLine after reset sequence

serilog / serilog-sinks-console

Write log events to System.Console as text or JSON, with ANSI theme support

Apache License 2.0

248 stars 72 forks source link

Fix ExceptionTokenRenderer to WriteLine after reset sequence #120

Closed matkoch closed 3 years ago

matkoch commented 3 years ago

What issue does this PR address? Fixes #119

Does this PR introduce a breaking change? I rather expect that some things magically start working for some users :)

Please check if the PR fulfills these requirements

[x] The commit follows our guidelines
[x] Unit Tests for the changes have been added (for bug fixes / features)

Other information: Since there were no breaking tests, I haven't added anything. I figure to properly test this, it would require some more test infrastructure. Hope you're still okay with it.

nblumhardt commented 3 years ago

LGTM; @serilog/reviewers-core anyone spot any issues/gotchas I might be missing? :-)

khellang commented 3 years ago

LGTM! 👌🏻

matkoch commented 3 years ago

Can anyone give an estimation when a new version could be released? I'd just like to know if it's worth waiting for my project to push a new NuGet package.

nblumhardt commented 3 years ago

Hi @matkoch - your changes are in 4.0.1-dev-00879, now on NuGet. We normally publish new "RTM" versions once the -dev-* version containing a change has had some use in the real-world.

If you can deploy the dev version, and let us know how it goes, that would be a useful data point towards planning a new release version.

HTH!

matkoch commented 3 years ago

Can confirm everything is working as expected:

matkoch commented 3 years ago

Hey @nblumhardt 👋

can you give any ETA for a release? I'm eagerly waiting to ship my nuget packages with the new serilog integration 😅

nblumhardt commented 3 years ago

On it - thanks!