serlo / frontend

Next.js app that serves serlo.org
https://serlo.org
Apache License 2.0
38 stars 10 forks source link

Remove support to wikimedia videos due to data privacy reasons #4312

Open hugotiburtino opened 1 week ago

hugotiburtino commented 1 week ago

Demo

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Nov 22, 2024 0:33am
github-actions[bot] commented 1 week ago

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Twenty-three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[...slug] 86.6 KB (🟡 +8 B) 191.48 KB
/___bot_or_not 98.09 KB (🟡 +8 B) 202.96 KB
/___editor_preview 629.43 KB (-12 B) 734.3 KB
/biologie 155.22 KB (🟡 +8 B) 260.1 KB
/chemie 155.22 KB (🟡 +8 B) 260.1 KB
/consent 41.02 KB (🟢 -19 B) 145.89 KB
/content-only/[...slug] 78.68 KB (🟡 +8 B) 183.56 KB
/editor 79.41 KB (🟡 +8 B) 184.29 KB
/entity/create/[type]/[taxonomyId] 649.7 KB (-12 B) 754.57 KB
/entity/repository/add-revision/[...id] 649.44 KB (-12 B) 754.31 KB
/entity/repository/compare/[entity_id]/[revision_id] 91.26 KB (🟡 +8 B) 196.13 KB
/informatik 155.23 KB (🟡 +8 B) 260.1 KB
/lerntipps 155.22 KB (🟡 +8 B) 260.1 KB
/license/detail/[id] 66.58 KB (🟡 +8 B) 171.46 KB
/mathe 155.22 KB (🟡 +8 B) 260.09 KB
/nachhaltigkeit 155.23 KB (🟡 +8 B) 260.1 KB
/page/create 649.42 KB (-12 B) 754.29 KB
/search 42.5 KB (🟢 -19 B) 147.38 KB
/spenden 54.84 KB (🟢 -14 B) 159.71 KB
/taxonomy/term/create/[parent_id]/[id] 649.17 KB (-12 B) 754.04 KB
/taxonomy/term/update/[id] 649.12 KB (-12 B) 753.99 KB
/user/profile/[username] 174.27 KB (🟡 +8 B) 279.14 KB
/user/settings 651.09 KB (-12 B) 755.96 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

hugotiburtino commented 1 week ago

Sorry, I've noticed a minor bug. I'll make it a draft and let you know when it is ok again

hugotiburtino commented 1 week ago

Now, it shows the video preview directly (No message "Video abspielen von....").

You can test at https://frontend-git-remove-wikimedia-video-serlo.vercel.app/___editor_preview with https://storage.googleapis.com/assets.serlo.org/wikimedia/Mfnf-linear-skalar2.webm