search

serrynaimo / 2018.jsconf.asia

3 stars 3 forks source link

PHP to static site #2

Open sebdeckers opened 7 years ago

sebdeckers commented 7 years ago

Hi @serrynaimo

I'm trying to convert the site to static files so it can be hosted on the http2.live CDN.

  1. Why is there /index.html and /index.php?
  2. What does this PHP statement do that new Date() couldn't? https://github.com/serrynaimo/2018.jsconf.asia/blob/00dcaac6a47f190637dc3f41abfa2c6378c35aef/index.php#L131
  3. Can we use feature detection instead of user agent sniffing? https://github.com/serrynaimo/2018.jsconf.asia/blob/00dcaac6a47f190637dc3f41abfa2c6378c35aef/lunch/index.php#L14
  4. Consider adding .DS_Store to a global .gitignore file on your system. (I'll clean them up here in the PR.)
serrynaimo commented 7 years ago

Cool. :)

I removed the php file. I want to use server time on the website to avoid bad client-side clocks and timezone issues. Maybe I can change it to request timing from a Lambda function or time-service instead of being rendered into the file. I'll ping you when done.

serrynaimo commented 7 years ago

Oh "site" is the up to date branch, btw, not "master". Sorry :) I just didn't expect anybody but me to be a contributor so it's a bit all over the place.