search

serverless-heaven / serverless-aws-alias

Alias support for Serverless 1.x
MIT License
189 stars 68 forks source link

fix the case of per-function custom Role #145

Closed sakichan closed 5 years ago

sakichan commented 5 years ago

I had a trouble with per-function custom Role, and needed to fix it.

I llooked around issues and pull requests, and found #87 and #88. My custom role is in the same stack, so @bencodner 's solution does not apply. So, I wrote another patch. It will cover cross-stack cases.

jmb12686 commented 5 years ago

Any progress on this PR? I seem to be having the same issue that this PR is supposed to fix (custom roles, same stack, for each lambda function)

Enase commented 5 years ago

could u add support for serverless-iam-roles-per-function?

Enase commented 5 years ago

Sorry, it works perfect with serverless-iam-roles-per-function. Why it's not merged yet?

Enase commented 5 years ago

tests added here https://github.com/HyperBrain/serverless-aws-alias/pull/157

dwkerwin commented 5 years ago

Any update on this? Did the merge fail just because the code coverage percentage was slightly decreased?

Enase commented 5 years ago

@dwkerwin serverless-iam-roles-per-function works perfect in latest release 2.0.1