Open ilyesBen opened 3 months ago
Could you fix failing tests? Thanks
Could you fix failing tests? Thanks
Sure, I will look into it.
Could you fix failing tests? Thanks
@j0k3r I have fixed test. I have removed all the checks around docker based functions as serverless-webpack
should not attempt to compile them IMO. I hope it makes sense.
What did you implement:
Closes #1884
Ignoring the handlers with the the
image.name
property the same way the ones withimage.uri
are ignored as they are lambda containers.How did you implement it:
How can we verify it:
Create a serverless template with both a lambda handler and a lambda container. The lambda container should have the
image.name
property poiting to anecr
image defined in the same template. The following example can be used:Run serverless package
The packager should not throw any error. It should package
functionHandler
and build the imagetest-image
for the functionfunctionContainer
(you would need to make sure you have a validDockerfile
in the root folder for the image to build).output in master
output in this branch
Todos:
Is this ready for review?: YES Is it a breaking change?: NO