feat: Refactor runtime configuration to allow for non-node runtimes - Githubissues

serverless / serverless-azure-functions

Serverless Azure Functions Plugin – Add Azure Functions support to the Serverless Framework

MIT License

267 stars 162 forks source link

feat: Refactor runtime configuration to allow for non-node runtimes #348

Closed tbarlow12 closed 5 years ago

tbarlow12 commented 5 years ago

What did you implement:

Refactored runtime to allow for non-node runtimes

How did you implement it:

Added FunctionRuntime configuration to provider
Extracting FunctionRuntime from runtime property of configuration within ConfigService
Refactored node-specific code in ARM template generation

How can we verify it:

Run a full deployment, check the ARM template

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

[x] Write tests and confirm existing functionality is not broken.
Validate via npm test
[x] Write documentation
[x] Ensure there are no lint errors.
Validate via npm run lint
Note: Some reported issues can be automatically fixed by running npm run lint:fix
[x] Make sure code coverage hasn't dropped
[x] Provide verification config / commands / resources
[x] Enable "Allow edits from maintainers" for this PR
[x] Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO