Closed tbarlow12 closed 4 years ago
Merging #362 into dev will increase coverage by
0.04%
. The diff coverage is94.73%
.
@@ Coverage Diff @@
## dev #362 +/- ##
==========================================
+ Coverage 94.44% 94.48% +0.04%
==========================================
Files 48 49 +1
Lines 1782 1868 +86
Branches 280 301 +21
==========================================
+ Hits 1683 1765 +82
- Misses 98 103 +5
+ Partials 1 0 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/test/mockFactory.ts | 90.67% <ø> (-1.04%) |
:arrow_down: |
src/config.ts | 100% <ø> (ø) |
:arrow_up: |
src/shared/constants.ts | 100% <ø> (ø) |
:arrow_up: |
src/services/coreToolsService.ts | 100% <100%> (ø) |
|
src/plugins/package/azurePackagePlugin.ts | 100% <100%> (ø) |
:arrow_up: |
src/plugins/azureBasePlugin.ts | 100% <100%> (ø) |
:arrow_up: |
src/services/rollbackService.ts | 100% <100%> (ø) |
:arrow_up: |
src/armTemplates/resources/appServicePlan.ts | 100% <100%> (ø) |
:arrow_up: |
src/services/configService.ts | 98.09% <100%> (+2.09%) |
:arrow_up: |
src/services/armService.ts | 96.8% <100%> (ø) |
:arrow_up: |
... and 9 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 673008b...b99afeb. Read the comment docs.
Hello,
May I ask when could you merge this PR?
And for python' function.js, if it trigger to http, we should change name of out as $return instead of res.
So, it's better to have an arguments to set --python or --nodejs
@tbarlow12
Closing in favor of coming PR
What did you implement:
Runtime support for Linux and Python
How did you implement it:
kind
to App Service plan and Function app ARM templatesreserved
andlinuxFxVersion
to Function App templatespawn
to Utils classCoreToolsService
to handle any CLI invocation offunc
CoreToolsService
to package & publish Linux apps/
instead of OS-specific path separator forfunction.json
file (works for both windows and linux)uploadZippedArfifactToFunctionApp
Important: Because core tools does not currently support publishing an existing package, any Linux applications will not clean built files. Also, because
func azure
(used in publishing) invokes the Azure CLI, I have not been able to get it to run properly as a child process. This will currently give the user the exact command to both publish their function app and then clean up the generated files.How can we verify it:
Specify the
linux
os in yourserverless.yml
like:and run
sls deploy
.Todos:
Note: Run
npm run test:ci
to run all validation checks on proposed changesValidate via
npm run lint
Note: Some reported issues can be automatically fixed by running
npm run lint:fix
Validate via
npm test
Is this ready for review?: YES
Is it a breaking change?: NO