feat: Refactored APIM policies into reusable builder component - Githubissues

serverless / serverless-azure-functions

Serverless Azure Functions Plugin – Add Azure Functions support to the Serverless Framework

MIT License

267 stars 162 forks source link

feat: Refactored APIM policies into reusable builder component #387

Closed wbreza closed 5 years ago

wbreza commented 5 years ago

What did you implement:

Resolves issue where APIM policy overwrites any changes done outside of serverless yaml config
Adds support for JWT validation
Adds support for IP filter

How did you implement it:

Adds new ApimPolicyBuilder which allows to parse existing policies and build new policies based on serverless yaml configuration.

How can we verify it:

Run unit tests via npm run test

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

[x] Ensure there are no lint errors.
Validate via npm run lint
Note: Some reported issues can be automatically fixed by running npm run lint:fix
[x] Write tests and confirm existing functionality is not broken.
Validate via npm test
[ ] Write documentation
[ ] Provide verification config / commands / resources
[x] Enable "Allow edits from maintainers" for this PR
[x] Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

pjlittle commented 5 years ago

great refactor. some gnarly config...