serverless / serverless-azure-functions

Serverless Azure Functions Plugin – Add Azure Functions support to the Serverless Framework
MIT License
267 stars 162 forks source link

fix: Specifying storage account name #425

Closed okumurays closed 4 years ago

okumurays commented 4 years ago

What did you implement:

Closes #396

How did you implement it:

Add statement about specifying storage account.

How can we verify it:

Could you check if my understanding is correct?

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

Is this ready for review?: YES
Is it a breaking change?: NO

codecov[bot] commented 4 years ago

Codecov Report

Merging #425 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files          48       48           
  Lines        1782     1782           
  Branches      245      280   +35     
=======================================
  Hits         1683     1683           
  Misses         98       98           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e85a8a...bd4cc30. Read the comment docs.

okumurays commented 4 years ago

Yes. Of course. I've already created my PR to dev branch. Could you review it again? https://github.com/serverless/serverless-azure-functions/pull/426

mydiemho commented 4 years ago

duplicate of #426