search

servicecatalog / oscm-rest-api

An RESTful API for the OSCM Platform.
https://openservicecatalogmanager.org
Apache License 2.0
2 stars 1 forks source link

Reorganize or refactor web.xml's #160

Open Crystalzord opened 5 years ago

Crystalzord commented 5 years ago

Summary I think we should refactor web.xml files or put the web.xml settings in one war file.

Details Since we are using maven cargo plugin to create an uberwar, the web.xml files are merged together. A merge-descriptor.xml file specifies which tags should be merged for the final oscm-rest-api.war (uberwar). I think that this causes an issue where every endpoint is available under all roles. This should be verified. If I am correct we could actually have one web.xml with all the settings, because in the current form they contain redundant tags (redundant, because the final uberwar contains all the settings anyway, so they could be actually written in only one place).

Acceptance criteria A clean solution for web.xml files is merged into the master branch.

adamczykba commented 5 years ago

Possible corelation with #44

Crystalzord commented 5 years ago

Possible corelation with https://github.com/servicecatalog/oscm-rest-api/issues/174