fix get_recommended_rendering_mode error check

servo / dwrote-rs

DirectWrite bindings and wrapper for Rust

11 stars 13 forks source link

fix get_recommended_rendering_mode error check #26

Closed lsalzman closed 6 years ago

lsalzman commented 6 years ago

This fixes downstream Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1505459

The error check in get_recommended_rendering_mode is incorrectly inverted, so every time this call actually succeeded, it would only return the default of natural-symmetric, regardless of what the render mode really should have been.

gw3583 commented 6 years ago

@bors-servo r+

bors-servo commented 6 years ago

:pushpin: Commit 17f6d7e has been approved by gw3583

bors-servo commented 6 years ago

:hourglass: Testing commit 17f6d7e1cccf8bf1ebd202692e955ef213641c14 with merge 4c8500d53a4e89630f3c5eb0326924fc748100b9...

bors-servo commented 6 years ago

:sunny: Test successful - status-appveyor Approved by: gw3583 Pushing 4c8500d53a4e89630f3c5eb0326924fc748100b9 to master...