make RECT public - Githubissues

servo / dwrote-rs

DirectWrite bindings and wrapper for Rust

11 stars 13 forks source link

make RECT public #28

Closed lsalzman closed 5 years ago

lsalzman commented 5 years ago

Currently glyph_run_analysis both takes and returns RECTs for several functions, but this type is not exported at all, which makes it difficult to manipulate. The only workaround is to currently import the winapi crate into a project, which is awkward just to retrieve a single type. It is much easier to just re-export the RECT type with dwrote so downstream use does not require an extra dep on winapi.

gw3583 commented 5 years ago

@bors-servo r+

bors-servo commented 5 years ago

:pushpin: Commit 30f6d20 has been approved by gw3583

bors-servo commented 5 years ago

:hourglass: Testing commit 30f6d2018b60fc6c314179b6c880187103b1332e with merge 2ed9822df72625302a7c23ca31c1f03869e3d1f5...

bors-servo commented 5 years ago

:sunny: Test successful - status-appveyor Approved by: gw3583 Pushing 2ed9822df72625302a7c23ca31c1f03869e3d1f5 to master...