search

servo / dwrote-rs

DirectWrite bindings and wrapper for Rust
11 stars 13 forks source link

Make NumberSubst optional in TextAnalysisSource #38

Closed davidhewitt closed 4 years ago

davidhewitt commented 4 years ago

According to the docs for IDWriteTextAnalysisSource (and my own testing of this PR) it is fine for the GetNumberSubstitution method to just return S_OK and set the pointer to null if no number substitution is needed.

This simplifies downstream usage slightly for use cases which aren't concerned about number substitution (such as my own).

davidhewitt commented 4 years ago

Thanks for merging #37. Could I please ping for this one to be merged too, as it's also approved?

jdm commented 4 years ago

@bors-servo r+

bors-servo commented 4 years ago

:pushpin: Commit 52f59f2 has been approved by jdm

bors-servo commented 4 years ago

:hourglass: Testing commit 52f59f261cd5579dcaf9621cf3bfdc5371b2e38d with merge c2486e8db9ef1a6fb51b126ead34d392a5060d82...

bors-servo commented 4 years ago

:sunny: Test successful - status-appveyor Approved by: jdm Pushing c2486e8db9ef1a6fb51b126ead34d392a5060d82 to master...