servo / dwrote-rs

DirectWrite bindings and wrapper for Rust
11 stars 13 forks source link

Re-use a fixed-size locale buffer #42

Closed davidhewitt closed 4 years ago

davidhewitt commented 4 years ago

Addressing the TODO in the code to achieve a little performance optimization.

Rather than making any new allocations we can just have an array of LOCALE_NAME_MAX_LENGTH characters.

jdm commented 4 years ago

@bors-servo r+ This looks reasonable; thanks!

bors-servo commented 4 years ago

:pushpin: Commit 8fbc81b has been approved by jdm

bors-servo commented 4 years ago

:hourglass: Testing commit 8fbc81be7c57f7b2bf33c57ec55113d5c4df3986 with merge 598449cba53895634b3a5585821c0cf41f3271a3...

bors-servo commented 4 years ago

:sunny: Test successful - status-appveyor Approved by: jdm Pushing 598449cba53895634b3a5585821c0cf41f3271a3 to master...