Closed philn closed 6 years ago
I just tested it and it works. Thank you!
OK, so we're not passing the stride info to WebRender when we create the ImageDescriptor objects, so when it's rendering our images, the (stride-width) pixels at the end of the line will appear at the start of the next line, which makes the rendering skewed. We can also use jya's upstream fix in Bug 1421187 to output i420 frames. I've pushed with these changes.
@bors-servo r=cpearce
:pushpin: Commit bfc742f has been approved by cpearce
:hourglass: Testing commit bfc742f0fecb014234902ced12458509eb6ebce2 with merge c31641adb3c3266f5f90447e5f3945eec2c47db5...
@bors-servo retry
@bors-servo r=cpearce
:pushpin: Commit d01da93 has been approved by cpearce
:hourglass: Testing commit d01da93bf2a3bcfaad21eae60d31ced874f40c65 with merge bedf04c46a46ee95de75837f86f00910db3e35a7...
Ah nuts, I forgot to git add
all of jya's upstream changes. :(
@bors-servo r=cpearce
(Retrying with the commit fixed to include the upstream changes I forgot)
:pushpin: Commit 3f5e908 has been approved by cpearce
:hourglass: Testing commit 3f5e908f1dbb9ac8210eb2b31d92c64d41a82e52 with merge 7caa1e582b97febd22a73760f86c7f7013510585...
:broken_heart: Test failed - status-travis
@bors-servo r=cpearce
:pushpin: Commit 2aa6129 has been approved by cpearce
:hourglass: Testing commit 2aa61290be9841fabc2f70f5e2fcee18f6de39ff with merge ff11e683ceeb6aa0168a927362854ee66d3961d7...
:sunny: Test successful - status-travis Approved by: cpearce Pushing ff11e683ceeb6aa0168a927362854ee66d3961d7 to master...
Can someone else with a mac please test this?